TKLDev - make clean not working properly but there's an easy fix

I'm converting one of my patches to utilzie the new tkldev appliance and have run into an issue with "make clean"

When I run 'make clean', I get an error that root.tmp is dirty

root@tkldev products/jenkins# make clean
error: root.tmp is dirty with manual changes. To continue: deck -D build/root.tmp
make: *** [clean] Error 1

Running "deck -D build/root.tmp" seems to succeed and then make clean works properly

I might take a look at fixing the makefile to perform this automatically and submit a pull request [after all, it's available to us all now :) ], but am concentrating on porting my patch(es) right now.

Replies (3)

archive updated

Reply 1 2013-07-23

I pushed the bugfix to the github repo, and updated the archive with new deck packages for both i386 and amd64.

apt-get update
apt-get install deck

deck --isdirty bug

Reply 2 2013-07-23

Hi Eric, this was a bug that caused deck --isdirty to return a false positive. I committed a fix. Alon will push out an upgrade to the deck package to make the fix really easy to apply::

apt-get install deck

Thanks guys

Reply 3 2013-07-23

Excellent. I had traced it to deck --isdirty returning the wrong value and had applied a slightly different fix but Liraz's is better. I undid my fix, updated deck, and it looks good.

Thanks again.